Briq
/
camelot-py
6
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove logger.info and use shutil.which to find pdftopng executable

pull/198/head
Vinayak Mehta 2021-07-04 20:02:47 +05:30
parent 4628be9251
commit c3b0fa30dc
No known key found for this signature in database
GPG Key ID: 2DE013537A15A9A4
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
camelot/backends/image_conversion.py
View File

@ -24,8 +24,6 @@ class ImageConversionBackend(object):
if self.use_fallback: if self.use_fallback:
for fallback in self.fallbacks: for fallback in self.fallbacks:
logger.info(f"Falling back on '{fallback}'")
try: try:
converter = backends[fallback]() converter = backends[fallback]()
converter.convert(pdf_path, png_path) converter.convert(pdf_path, png_path)

9
camelot/backends/poppler_backend.py
View File

@ -1,11 +1,18 @@
# -*- coding: utf-8 -*- # -*- coding: utf-8 -*-
import shutil
import subprocess import subprocess
class PopplerBackend(object): class PopplerBackend(object):
def convert(self, pdf_path, png_path): def convert(self, pdf_path, png_path):
pdftopng_command = ["pdftopng", pdf_path, png_path] pdftopng_executable = shutil.which("pdftopng")
if pdftopng_executable is None:
raise OSError(
"pdftopng is not installed. Please install it using the `pip install pdftopng` command."
)
pdftopng_command = [pdftopng_executable, pdf_path, png_path]
try: try:
subprocess.check_output( subprocess.check_output(