Feat/confirm actions (#2)

* Working wrapper for actions

* checking permissions for action

* Refactor/clean change_confirmation template a bit

* Update README

* Update README

* Adding unit tests for confirm_action decorator

* Updated tests/readme

* Update after testing upload to test pypi

* Clean up and format code

Co-authored-by: Thu Trang Pham <thu@joinmodernhealth.com>

admin_confirm/templates/admin/action_confirmation.html

@@ -0,0 +1,56 @@
+{% extends "admin/base_site.html" %}
+{% load i18n l10n admin_urls static %}
+
+{% block extrahead %}
+    {{ block.super }}
+    {{ media }}
+    <script src="{% static 'admin/js/cancel.js' %}" async></script>
+{% endblock %}
+
+{% block extrastyle %}
+    {{ block.super }}
+    <link rel="stylesheet" type="text/css" href="{% static "admin/css/forms.css" %}">
+    <link rel="stylesheet" type="text/css" href="{% static "admin/css/confirmation.css" %}">
+{% endblock %}
+
+{% block bodyclass %}{{ block.super }} app-{{ opts.app_label }} model-{{ opts.model_name }} change-confirmation{% endblock %}
+
+{% block breadcrumbs %}
+<div class="breadcrumbs">
+<a href="{% url 'admin:index' %}">{% trans 'Home' %}</a>
+&rsaquo; <a href="{% url 'admin:app_list' app_label=opts.app_label %}">{{ opts.app_config.verbose_name }}</a>
+&rsaquo; <a href="{% url opts|admin_urlname:'changelist' %}">{{ opts.verbose_name_plural|capfirst }}</a>
+&rsaquo; {% trans 'Confirm Action' %}
+</div>
+{% endblock %}
+
+{% block content %}
+{% if has_perm %}
+  <p>{% trans 'Are you sure you want to perform action' %} {{ action_display_name }} {% trans 'on the following' %} {{ opts.verbose_name_plural|capfirst }}?</p>
+  <ul>
+    {% for obj in queryset %}
+      <li>{{ obj }}</li>
+    {% endfor %}
+  </ul>
+  <form method="post">{% csrf_token %}
+  {% for obj in queryset %}
+    <input type="hidden" name="{{ action_checkbox_name }}" value="{{ obj.pk|unlocalize }}">
+  {% endfor %}
+  <input type="hidden" name="action" value="{{ action }}">
+  <div class="submit-row">
+      <input type="submit" value="{% trans 'Yes, I’m sure' %}" name="_confirm_action">
+      <p class="deletelink-box">
+          <a href="{% url opts|admin_urlname:'changelist' %}" class="button cancel-link">{% trans "No, go back" %}</a>
+      </p>
+  </div>
+  </form>
+{% else %}
+  <p>{% trans "You don't have permissions to perform action" %} {{ action_display_name }} {% trans 'on' %} {{ opts.verbose_name_plural|capfirst }}</p>
+  <br/>
+  <div class="submit-row">
+      <p class="deletelink-box">
+          <a href="{% url opts|admin_urlname:'changelist' %}" class="button cancel-link">{% trans "Go back" %}</a>
+      </p>
+  </div>
+{% endif %}
+{% endblock %}

admin_confirm/templates/admin/change_confirmation.html

@@ -30,35 +30,19 @@
 {% endblock %}
 
 {% block content %}
-{% if add %}
-    <p>{% blocktrans with escaped_object=object %}Are you sure you want to add the {{ model_name }}?{% endblocktrans %}</p>
-    {% if changed_data %}
-      <div class="changed-data">
-          <p><b>Confirm Values:</b></p>
-          <table>
-    {% for field, values in changed_data.items %}
-        <tr><th style="text-align: right">{{ field }}:</th><td>{{ values.1 }}</td></tr>
-    {% endfor %}
-    </table>
-      </div>
-    <form method="post" action="{% url opts|admin_urlname:'add'%}">{% csrf_token %}
+
+  {% if add %}
+      <p>{% blocktrans with escaped_object=object %}Are you sure you want to add the {{ model_name }}?{% endblocktrans %}</p>
+      {% include "admin/change_data.html" %}
+      <form method="post" action="{% url opts|admin_urlname:'add'%}">{% csrf_token %}
+
+  {% else %}
+
+    <p>{% blocktrans with escaped_object=object %}Are you sure you want to change the {{ model_name }} "{{ object_name }}"?{% endblocktrans %}</p>
+    {% include "admin/change_data.html" %}
+    <form method="post" action="{% url opts|admin_urlname:'change' object_id|admin_urlquote %}">{% csrf_token %}
   {% endif %}
-{% else %}
-  <p>{% blocktrans with escaped_object=object %}Are you sure you want to change the {{ model_name }} "{{ object_name }}"?{% endblocktrans %}</p>
-  {% if changed_data %}
-      <div class="changed-data">
-    <p><b>Confirm Values:</b></p>
-    <table>
-    <tr><th>Field</th><th>Current Value</th><th>New Value</th></tr>
-    {% for field, values in changed_data.items %}
-        <tr><td>{{ field }}</td><td>{{ values.0 }}</td><td>{{ values.1 }}</td></tr>
-    {% endfor %}
-    </table>
-      </div>
-  {% endif %}
-  <form method="post" action="{% url opts|admin_urlname:'change' object_id|admin_urlquote %}">{% csrf_token %}
-{% endif %}
-  <div>
+
     {% for key, value in form_data.items %}
         <input type="hidden" name="{{ key }}" value="{{ value }}">
     {% endfor %}
@@ -70,6 +54,5 @@
             <a href="#" class="button cancel-link">{% trans "No, continue to edit" %}</a>
         </p>
     </div>
-  </div>
   </form>
 {% endblock %}

admin_confirm/templates/admin/change_data.html

@@ -0,0 +1,11 @@
+{% if changed_data %}
+    <div class="changed-data">
+    <p><b>Confirm Values:</b></p>
+    <table>
+        <tr><th>Field</th><th>Current Value</th><th>New Value</th></tr>
+        {% for field, values in changed_data.items %}
+            <tr><td>{{ field }}</td><td>{{ values.0 }}</td><td>{{ values.1 }}</td></tr>
+        {% endfor %}
+    </table>
+    </div>
+{% endif %}