From 6368a6c47e4bc5bf45ffcdd2543c9b805c5ff4a2 Mon Sep 17 00:00:00 2001
From: Mauro Santos <mauro@scandit.com>
Date: Wed, 16 Feb 2022 09:16:58 +0100
Subject: [PATCH] Remove public disclosures of the lib's version

---
 admin_interface/templates/admin/base_site.html        | 10 ++--------
 .../templates/admin_interface/favicon.html            |  2 +-
 .../templates/admin_interface/foldable-apps.html      |  6 +++---
 .../templates/admin_interface/related-modal.html      |  8 ++++----
 admin_interface/templatetags/admin_interface_tags.py  |  4 ----
 tests/test_templatetags.py                            | 11 -----------
 6 files changed, 10 insertions(+), 31 deletions(-)

diff --git a/admin_interface/templates/admin/base_site.html b/admin_interface/templates/admin/base_site.html
index e02272d..2ecfd98 100644
--- a/admin_interface/templates/admin/base_site.html
+++ b/admin_interface/templates/admin/base_site.html
@@ -8,13 +8,8 @@
 
 {% block extrastyle %}
 {% get_admin_interface_theme as theme %}
-{% get_admin_interface_version as version %}
 {% get_current_language as current_lang %}
 <style type="text/css">
-/*
-django-admin-interface {{ version }}
-https://github.com/fabiocaccamo/django-admin-interface
-*/
 {% include "admin_interface/css/admin-interface.css" %}
 {% include "admin_interface/css/admin-interface-fix.css" %}
 {% include "admin_interface/css/form-controls.css" %}
@@ -40,11 +35,10 @@ https://github.com/fabiocaccamo/django-admin-interface
 {% block blockbots %}
 {{ block.super }}
 {% get_admin_interface_theme as theme %}
-{% get_admin_interface_version as version %}
 {# https://github.com/elky/django-flat-responsive#important-note #}
 <meta name="viewport" content="user-scalable=no, width=device-width, initial-scale=1.0, maximum-scale=1.0">
-<link rel="stylesheet" type="text/css" href="{% static 'admin/css/responsive.css' %}?v={{ version }}">
-<link rel="stylesheet" type="text/css" href="{% static 'admin/css/responsive_rtl.css' %}?v={{ version }}" />
+<link rel="stylesheet" type="text/css" href="{% static 'admin/css/responsive.css' %}">
+<link rel="stylesheet" type="text/css" href="{% static 'admin/css/responsive_rtl.css' %}" />
 {% include "admin_interface/favicon.html" %}
 {% include "admin_interface/foldable-apps.html" %}
 {% include "admin_interface/related-modal.html" %}
diff --git a/admin_interface/templates/admin_interface/favicon.html b/admin_interface/templates/admin_interface/favicon.html
index 6631c8e..c015359 100644
--- a/admin_interface/templates/admin_interface/favicon.html
+++ b/admin_interface/templates/admin_interface/favicon.html
@@ -3,7 +3,7 @@
 {% if theme.favicon %}
 <link rel="icon" href="{{ theme.favicon.url }}">
 {% if theme.env_visible_in_favicon %}
-<script type="text/javascript" src="{% static 'admin_interface/favico/favico-0.3.10-patched.min.js' %}?v={{ version }}"></script>
+<script type="text/javascript" src="{% static 'admin_interface/favico/favico-0.3.10-patched.min.js' %}"></script>
 <script type="text/javascript">
 var favicon = new Favico({
     type: 'circle',
diff --git a/admin_interface/templates/admin_interface/foldable-apps.html b/admin_interface/templates/admin_interface/foldable-apps.html
index b66fc04..aa57e74 100644
--- a/admin_interface/templates/admin_interface/foldable-apps.html
+++ b/admin_interface/templates/admin_interface/foldable-apps.html
@@ -1,6 +1,6 @@
 {% load static %}
 
 {% if theme.foldable_apps %}
-<link rel="stylesheet" type="text/css" href="{% static 'admin_interface/foldable-apps/foldable-apps.css' %}?v={{ version }}">
-<script type="text/javascript" src="{% static 'admin_interface/foldable-apps/foldable-apps.js' %}?v={{ version }}"></script>
-{% endif %}
+<link rel="stylesheet" type="text/css" href="{% static 'admin_interface/foldable-apps/foldable-apps.css' %}">
+<script type="text/javascript" src="{% static 'admin_interface/foldable-apps/foldable-apps.js' %}"></script>
+{% endif %}
\ No newline at end of file
diff --git a/admin_interface/templates/admin_interface/related-modal.html b/admin_interface/templates/admin_interface/related-modal.html
index a1e707e..0c7de89 100644
--- a/admin_interface/templates/admin_interface/related-modal.html
+++ b/admin_interface/templates/admin_interface/related-modal.html
@@ -1,7 +1,7 @@
 {% load static %}
 
 {% if theme.related_modal_active %}
-<link rel="stylesheet" type="text/css" href="{% static 'admin_interface/magnific-popup/magnific-popup.css' %}?v={{ version }}">
-<script type="text/javascript" src="{% static 'admin_interface/magnific-popup/jquery.magnific-popup.js' %}?v={{ version }}"></script>
-<script type="text/javascript" src="{% static 'admin_interface/related-modal/related-modal.js' %}?v={{ version }}"></script>
-{% endif %}
+<link rel="stylesheet" type="text/css" href="{% static 'admin_interface/magnific-popup/magnific-popup.css' %}">
+<script type="text/javascript" src="{% static 'admin_interface/magnific-popup/jquery.magnific-popup.js' %}"></script>
+<script type="text/javascript" src="{% static 'admin_interface/related-modal/related-modal.js' %}"></script>
+{% endif %}
\ No newline at end of file
diff --git a/admin_interface/templatetags/admin_interface_tags.py b/admin_interface/templatetags/admin_interface_tags.py
index a198109..f28234f 100644
--- a/admin_interface/templatetags/admin_interface_tags.py
+++ b/admin_interface/templatetags/admin_interface_tags.py
@@ -9,7 +9,6 @@ from django.utils import translation
 from admin_interface.cache import get_cached_active_theme, set_cached_active_theme
 from admin_interface.compat import NoReverseMatch, reverse
 from admin_interface.models import Theme
-from admin_interface.version import __version__
 
 import re
 
@@ -74,6 +73,3 @@ def get_admin_interface_theme(context):
     return theme
 
 
-@simple_tag(takes_context=False)
-def get_admin_interface_version():
-    return __version__
diff --git a/tests/test_templatetags.py b/tests/test_templatetags.py
index 6a1be0d..728cc78 100644
--- a/tests/test_templatetags.py
+++ b/tests/test_templatetags.py
@@ -8,7 +8,6 @@ from django.template import Context, Template
 
 from admin_interface.models import Theme
 from admin_interface.templatetags import admin_interface_tags as templatetags
-from admin_interface.version import __version__
 
 
 class AdminInterfaceTemplateTagsTestCase(TestCase):
@@ -123,13 +122,3 @@ class AdminInterfaceTemplateTagsTestCase(TestCase):
             context,
         )
         self.assertEqual(rendered, "Django")
-
-    def test_get_version(self):
-        version = templatetags.get_admin_interface_version()
-        self.assertEqual(version, __version__)
-        rendered = self.__render_template(
-            "{% load admin_interface_tags %}"
-            "{% get_admin_interface_version as version %}"
-            "{{ version }}"
-        )
-        self.assertEqual(rendered, __version__)