From 8bdbf3146509a9967fa6f92b1406c35f48cde0a8 Mon Sep 17 00:00:00 2001 From: Fabio Caccamo Date: Tue, 3 Dec 2019 11:34:26 +0100 Subject: [PATCH] Improved code quality. --- admin_interface/static/admin/js/cancel.js | 4 +++- admin_interface/static/admin/js/popup_response.js | 4 ++-- .../static/admin_interface/related-modal/related-modal.js | 8 +++++--- 3 files changed, 10 insertions(+), 6 deletions(-) diff --git a/admin_interface/static/admin/js/cancel.js b/admin_interface/static/admin/js/cancel.js index 2e08819..fec8fb2 100644 --- a/admin_interface/static/admin/js/cancel.js +++ b/admin_interface/static/admin/js/cancel.js @@ -1,3 +1,5 @@ +/** global: django */ + if (typeof(django) !== 'undefined' && typeof(django.jQuery) !== 'undefined') { (function($) { 'use strict'; @@ -14,5 +16,5 @@ if (typeof(django) !== 'undefined' && typeof(django.jQuery) !== 'undefined') { return false; }); }); - })(django.jQuery); + }(django.jQuery)); } \ No newline at end of file diff --git a/admin_interface/static/admin/js/popup_response.js b/admin_interface/static/admin/js/popup_response.js index 5c498f6..d5b30b0 100644 --- a/admin_interface/static/admin/js/popup_response.js +++ b/admin_interface/static/admin/js/popup_response.js @@ -13,7 +13,7 @@ openerRef = windowRef.parent; modalRef = { name: openerRef.id_to_windowname(widgetName), - close: function(){ + close: function() { openerRef.dismissRelatedObjectModal(); } }; @@ -49,4 +49,4 @@ break; } -})(); \ No newline at end of file +}()); \ No newline at end of file diff --git a/admin_interface/static/admin_interface/related-modal/related-modal.js b/admin_interface/static/admin_interface/related-modal/related-modal.js index 39062ec..e1b2fe4 100644 --- a/admin_interface/static/admin_interface/related-modal/related-modal.js +++ b/admin_interface/static/admin_interface/related-modal/related-modal.js @@ -1,3 +1,5 @@ +/** global: django */ + if (typeof(django) !== 'undefined' && typeof(django.jQuery) !== 'undefined') { (function($) { @@ -39,7 +41,7 @@ if (typeof(django) !== 'undefined' && typeof(django.jQuery) !== 'undefined') var linkEl = $(this); var href = (linkEl.attr('href') || ''); - if (href == '') { + if (href === '') { return; } @@ -99,7 +101,7 @@ if (typeof(django) !== 'undefined' && typeof(django.jQuery) !== 'undefined') // if the current window is inside an iframe, it means that it is already in a modal, // append an additional css class to the modal to offer more customization - if (window.top != window.self) { + if (window.top !== window.self) { iframeInternalModalClass += ' related-modal__nested'; } @@ -145,5 +147,5 @@ if (typeof(django) !== 'undefined' && typeof(django.jQuery) !== 'undefined') presentRelatedObjectModalOnClickOn('a.dynamic_raw_id-related-lookup', true); }); - })(django.jQuery); + }(django.jQuery)); } \ No newline at end of file