Increase `flake8` checks.

master
Fabio Caccamo 2023-01-24 18:19:04 +01:00
parent d15c0c10c2
commit ecc1cd77de
5 changed files with 23 additions and 18 deletions

View File

@ -1,5 +1,5 @@
[flake8] [flake8]
ignore = E203, E266, E501, W503, F403, F401, F841 ignore = W503
max-line-length = 89 max-line-length = 89
max-complexity = 10 max-complexity = 10
select = B,C,E,F,W,T4,B9 select = B,C,E,F,W,T4,B9

View File

@ -25,7 +25,7 @@ class Migration(migrations.Migration):
field=colorfield.fields.ColorField( field=colorfield.fields.ColorField(
blank=True, blank=True,
default="#E74C3C", default="#E74C3C",
help_text="(red: #E74C3C, orange: #E67E22, yellow: #F1C40F, green: #2ECC71, blue: #3498DB)", help_text="(red: #E74C3C, orange: #E67E22, yellow: #F1C40F, green: #2ECC71, blue: #3498DB)", # noqa: E501
max_length=10, max_length=10,
verbose_name="color", verbose_name="color",
), ),

View File

@ -107,12 +107,16 @@ class Theme(models.Model):
verbose_name=_("favicon"), verbose_name=_("favicon"),
) )
env_name = models.CharField(blank=True, max_length=50, verbose_name=_("name")) env_name = models.CharField(
blank=True,
max_length=50,
verbose_name=_("name"),
)
env_color = ColorField( env_color = ColorField(
blank=True, blank=True,
default="#E74C3C", default="#E74C3C",
help_text=_( help_text=_(
"(red: #E74C3C, orange: #E67E22, yellow: #F1C40F, green: #2ECC71, blue: #3498DB)" "(red: #E74C3C, orange: #E67E22, yellow: #F1C40F, green: #2ECC71, blue: #3498DB)" # noqa: E501
), ),
max_length=10, max_length=10,
verbose_name=_("color"), verbose_name=_("color"),
@ -223,7 +227,8 @@ class Theme(models.Model):
verbose_name=_("link hover color"), verbose_name=_("link hover color"),
) )
css_module_rounded_corners = models.BooleanField( css_module_rounded_corners = models.BooleanField(
default=True, verbose_name=_("rounded corners") default=True,
verbose_name=_("rounded corners"),
) )
css_generic_link_color = ColorField( css_generic_link_color = ColorField(
@ -285,7 +290,10 @@ class Theme(models.Model):
verbose_name=_("text color"), verbose_name=_("text color"),
) )
related_modal_active = models.BooleanField(default=True, verbose_name=_("active")) related_modal_active = models.BooleanField(
default=True,
verbose_name=_("active"),
)
related_modal_background_color = ColorField( related_modal_background_color = ColorField(
blank=True, blank=True,
default="#000000", default="#000000",

View File

@ -1,9 +1,8 @@
import random import random
import shutil import shutil
from unittest import expectedFailure
from django.conf import settings from django.conf import settings
from django.test import TestCase, TransactionTestCase from django.test import TestCase
from admin_interface.models import Theme from admin_interface.models import Theme
@ -45,25 +44,25 @@ class AdminInterfaceModelsTestCase(TestCase):
def test_default_theme_activated_after_update_if_multiple_active_themes(self): def test_default_theme_activated_after_update_if_multiple_active_themes(self):
Theme.objects.all().delete() Theme.objects.all().delete()
theme_1 = Theme.objects.create(name="Custom 1", active=True) Theme.objects.create(name="Custom 1", active=True)
theme_2 = Theme.objects.create(name="Custom 2", active=True) Theme.objects.create(name="Custom 2", active=True)
theme_3 = Theme.objects.create(name="Custom 3", active=True) Theme.objects.create(name="Custom 3", active=True)
Theme.objects.update(active=False) Theme.objects.update(active=False)
Theme.objects.update(active=True) Theme.objects.update(active=True)
self.__test_active_theme() self.__test_active_theme()
def test_default_theme_activated_on_active_theme_deleted(self): def test_default_theme_activated_on_active_theme_deleted(self):
Theme.objects.all().delete() Theme.objects.all().delete()
theme_1 = Theme.objects.create(name="Custom 1", active=True) Theme.objects.create(name="Custom 1", active=True)
theme_2 = Theme.objects.create(name="Custom 2", active=True) Theme.objects.create(name="Custom 2", active=True)
theme_3 = Theme.objects.create(name="Custom 3", active=True) Theme.objects.create(name="Custom 3", active=True)
Theme.objects.filter(pk=Theme.objects.get_active().pk).delete() Theme.objects.filter(pk=Theme.objects.get_active().pk).delete()
self.__test_active_theme() self.__test_active_theme()
def test_last_theme_activated_on_multiple_themes_created(self): def test_last_theme_activated_on_multiple_themes_created(self):
Theme.objects.all().delete() Theme.objects.all().delete()
theme_1 = Theme.objects.create(name="Custom 1", active=True) Theme.objects.create(name="Custom 1", active=True)
theme_2 = Theme.objects.create(name="Custom 2", active=True) Theme.objects.create(name="Custom 2", active=True)
theme_3 = Theme.objects.create(name="Custom 3", active=True) theme_3 = Theme.objects.create(name="Custom 3", active=True)
self.assertEqual(Theme.objects.get_active().pk, theme_3.pk) self.assertEqual(Theme.objects.get_active().pk, theme_3.pk)
self.__test_active_theme() self.__test_active_theme()

View File

@ -1,5 +1,3 @@
from unittest import skipIf
from django.test import TestCase from django.test import TestCase
from admin_interface.models import Theme from admin_interface.models import Theme