Avoid unnecessary db queries: perform the update iff the order field has changed.

2017-03-08 23:28:40 -05:00
parent f2f5daf831
commit eb5a9e0a8a
1 changed files with 5 additions and 3 deletions
@@ -297,6 +297,8 @@ class SortableAdmin(SortableAdminBase, ModelAdmin):

                for index in indexes:
                    obj = objects_dict.get(index)
+                    # perform the update iff the order field has changed
+                    if getattr(obj, order_field_name) != start_index:
                        setattr(obj, order_field_name, start_index)
                        # only update the object's order field
                        obj.save(update_fields=(order_field_name,))