Briq
/
django-polymorphic
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

add pre_save_polymorphic(), split from save()

fix_request_path_info
Bert Constantin 2010-01-17 19:53:25 +01:00
parent 2729187591
commit 889ce78f2e
1 changed files with 16 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
poly/polymorphic.py
View File

@ -746,10 +746,12 @@ def _translate_polymorphic_filter_spec(queryset_model, field_path, field_val):
# filter expression contains '___' (i.e. filter for polymorphic field) # filter expression contains '___' (i.e. filter for polymorphic field)
# => get the model class specified in the filter expression # => get the model class specified in the filter expression
# TODO: if app not given, just model name => try to find model in any app??
classname, sep, pure_field_path = field_path.partition('___') classname, sep, pure_field_path = field_path.partition('___')
if '__' in classname: appname, sep, classname = classname.partition('__') if '__' in classname: appname, sep, classname = classname.partition('__')
else: appname = queryset_model._meta.app_label else: appname = queryset_model._meta.app_label
model = models.get_model(appname, classname) model = models.get_model(appname, classname)
assert model, 'model %s (in app %s) not found!' % (modelname, appname)
if not issubclass(model, queryset_model): if not issubclass(model, queryset_model):
e = 'queryset filter error: "' + model.__name__ + '" is not derived from "' + queryset_model.__name__ + '"' e = 'queryset filter error: "' + model.__name__ + '" is not derived from "' + queryset_model.__name__ + '"'
raise AssertionError(e) raise AssertionError(e)
@ -868,7 +870,7 @@ class PolymorphicModelBase(ModelBase):
add_managers = []; add_managers_keys = set() add_managers = []; add_managers_keys = set()
for base in self.__mro__[1:]: for base in self.__mro__[1:]:
if not issubclass(base, models.Model): continue if not issubclass(base, models.Model): continue
if not getattr(base,'polymorphic_model_marker',None): continue # leave managers of non-polym. models alone if not getattr(base, 'polymorphic_model_marker', None): continue # leave managers of non-polym. models alone
for key, manager in base.__dict__.items(): for key, manager in base.__dict__.items():
if type(manager) == models.manager.ManagerDescriptor: manager = manager.manager if type(manager) == models.manager.ManagerDescriptor: manager = manager.manager
@ -948,19 +950,25 @@ class PolymorphicModel(models.Model):
objects = PolymorphicManager() objects = PolymorphicManager()
base_objects = models.Manager() base_objects = models.Manager()
def save(self, *args, **kwargs): def pre_save_polymorphic(self):
"""Overridden model save function which supports the polymorphism """
functionality. If your derived class overrides save() as well, then you Normally not needed - this function may be called manually in special use-cases.
need to take care that you correctly call the save() method of
the superclass.
When the object is saved for the first time, we store its real class and app name When the object is saved for the first time, we store its real class and app name
into p_classname and p_appname. When the object later is retrieved by into p_classname and p_appname. When the object later is retrieved by
PolymorphicQuerySet, it uses these fields to figure out the real type of this object PolymorphicQuerySet, it uses these fields to figure out the real type of this object
(used by PolymorphicQuerySet._get_real_instances)""" (used by PolymorphicQuerySet._get_real_instances)
"""
if not self.p_classname: if not self.p_classname:
self.p_classname = self.__class__.__name__ self.p_classname = self.__class__.__name__
self.p_appname = self.__class__._meta.app_label self.p_appname = self.__class__._meta.app_label
def save(self, *args, **kwargs):
"""Overridden model save function which supports the polymorphism
functionality (through pre_save). If your derived class overrides
save() as well, then you need to take care that you correctly call
the save() method of the superclass."""
self.pre_save_polymorphic()
return super(PolymorphicModel, self).save(*args, **kwargs) return super(PolymorphicModel, self).save(*args, **kwargs)
def get_real_instance_class(self): def get_real_instance_class(self):
@ -1028,3 +1036,4 @@ class PolymorphicModel(models.Model):
if f != last: out += ', ' if f != last: out += ', '
return '<' + out + '>' return '<' + out + '>'