From c4379dc6a70ec17a1b42d3c5fcf400783fcef7ab Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Cristi=20V=C3=AEjdea?= <cristi@cvjd.me>
Date: Wed, 10 Jan 2018 10:18:22 +0100
Subject: [PATCH] Run testproj in a Heroku demo app (#38)

* Add Heroku configuration
* Add links in API description
* Read database connection string from DATABASE_URL environment variable
* Restructure settings files for production
* Run server using gunicorn and servce static files with whitenoise
* Install drf-yasg from source instead of pypi in testproj
* Add readme links to demo app
---
 .gitignore                                    |  1 +
 .idea/drf-yasg.iml                            |  4 +--
 .travis.yml                                   |  2 +-
 Procfile                                      |  2 ++
 README.rst                                    |  5 +++
 app.json                                      | 17 +++++++++
 docs/conf.py                                  |  2 +-
 requirements.txt                              |  1 +
 requirements/dev.txt                          |  3 ++
 requirements/heroku.txt                       |  9 +++++
 requirements/testproj.txt                     |  2 ++
 requirements/tox.txt                          |  2 --
 runtime.txt                                   |  1 +
 setup.py                                      | 32 ++++++++++++-----
 src/drf_yasg/inspectors/field.py              |  6 ++--
 testproj/createsuperuser.py                   | 10 ++++--
 testproj/manage.py                            |  2 +-
 testproj/requirements.txt                     |  5 +--
 testproj/testproj/settings/__init__.py        |  0
 .../{settings.py => settings/base.py}         | 31 ++++++----------
 testproj/testproj/settings/heroku.py          | 35 +++++++++++++++++++
 testproj/testproj/settings/local.py           | 24 +++++++++++++
 testproj/testproj/urls.py                     | 24 ++++++++++++-
 testproj/testproj/wsgi.py                     |  2 +-
 tests/reference.yaml                          |  6 +++-
 tox.ini                                       | 10 +++---
 26 files changed, 188 insertions(+), 50 deletions(-)
 create mode 100644 Procfile
 create mode 100644 app.json
 create mode 100644 requirements.txt
 create mode 100644 requirements/heroku.txt
 create mode 100644 runtime.txt
 create mode 100644 testproj/testproj/settings/__init__.py
 rename testproj/testproj/{settings.py => settings/base.py} (85%)
 create mode 100644 testproj/testproj/settings/heroku.py
 create mode 100644 testproj/testproj/settings/local.py

diff --git a/.gitignore b/.gitignore
index be34809..0dffda8 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,5 +1,6 @@
 node_modules/
 testproj/db.sqlite3
+testproj/staticfiles
 .vscode/
 
 # Created by .ignore support plugin (hsz.mobi)
diff --git a/.idea/drf-yasg.iml b/.idea/drf-yasg.iml
index cab41e2..c0ef6ba 100644
--- a/.idea/drf-yasg.iml
+++ b/.idea/drf-yasg.iml
@@ -4,7 +4,7 @@
     <facet type="django" name="Django">
       <configuration>
         <option name="rootFolder" value="$MODULE_DIR$/testproj" />
-        <option name="settingsModule" value="testproj/settings.py" />
+        <option name="settingsModule" value="testproj/settings/local.py" />
         <option name="manageScript" value="manage.py" />
         <option name="environment" value="&lt;map/&gt;" />
         <option name="doNotUseTestRunner" value="false" />
@@ -32,4 +32,4 @@
     <option name="projectConfiguration" value="py.test" />
     <option name="PROJECT_TEST_RUNNER" value="py.test" />
   </component>
-</module>
\ No newline at end of file
+</module>
diff --git a/.travis.yml b/.travis.yml
index a46a50d..d39302e 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -38,7 +38,7 @@ jobs:
         distributions: "sdist bdist_wheel"
 
   allow_failures:
-    - env: TOXENV=flake8
+    - env: TOXENV=lint
     - env: DRF=master
 
   fast_finish: true
diff --git a/Procfile b/Procfile
new file mode 100644
index 0000000..4141a3b
--- /dev/null
+++ b/Procfile
@@ -0,0 +1,2 @@
+release: python testproj/manage.py migrate && python testproj/manage.py shell -c "import createsuperuser"
+web: gunicorn --chdir testproj testproj.wsgi --log-file -
diff --git a/README.rst b/README.rst
index f295d9b..079a867 100644
--- a/README.rst
+++ b/README.rst
@@ -20,6 +20,11 @@ Resources:
 * **Source**: https://github.com/axnsan12/drf-yasg/
 * **Documentation**: https://drf-yasg.readthedocs.io/
 * **Changelog**: https://drf-yasg.readthedocs.io/en/stable/changelog.html
+* **Live demo**: https://drf-yasg-demo.herokuapp.com/
+
+.. image:: https://www.herokucdn.com/deploy/button.svg
+   :target: https://heroku.com/deploy?template=https://github.com/axnsan12/drf-yasg
+   :alt: heroku deploy button
 
 ********
 Features
diff --git a/app.json b/app.json
new file mode 100644
index 0000000..becfad0
--- /dev/null
+++ b/app.json
@@ -0,0 +1,17 @@
+{
+  "name": "drf-yasg Demo app",
+  "description": "A demonstrative app using https://github.com/axnsan12/drf-yasg",
+  "repository": "https://github.com/axnsan12/drf-yasg",
+  "logo": "https://swaggerhub.com/wp-content/uploads/2017/10/Swagger-Icon.svg",
+  "keywords": [
+    "django",
+    "django-rest-framework",
+    "swagger",
+    "openapi"
+  ],
+  "env": {
+    "DJANGO_SETTINGS_MODULE": "testproj.settings.heroku",
+    "DJANGO_SECRET_KEY": "m76=^#=z7xv5^(o%4dv9w7+1_c)y2m6)1ogjx%s@9$1^nupry="
+  },
+  "success_url": "/"
+}
diff --git a/docs/conf.py b/docs/conf.py
index c4856de..5b7642a 100644
--- a/docs/conf.py
+++ b/docs/conf.py
@@ -205,7 +205,7 @@ sys.path.insert(0, os.path.abspath('../src'))
 
 # activate the Django testproj to be able to succesfully import drf_yasg
 sys.path.insert(0, os.path.abspath('../testproj'))
-os.putenv('DJANGO_SETTINGS_MODULE', 'testproj.settings')
+os.putenv('DJANGO_SETTINGS_MODULE', 'testproj.settings.local')
 
 from django.conf import settings  # noqa: E402
 
diff --git a/requirements.txt b/requirements.txt
new file mode 100644
index 0000000..56e6917
--- /dev/null
+++ b/requirements.txt
@@ -0,0 +1 @@
+-r requirements/heroku.txt
diff --git a/requirements/dev.txt b/requirements/dev.txt
index a57303e..d3b2a9e 100644
--- a/requirements/dev.txt
+++ b/requirements/dev.txt
@@ -2,3 +2,6 @@
 -r tox.txt
 -r test.txt
 -r lint.txt
+
+tox-battery>=0.5
+detox>=0.11
diff --git a/requirements/heroku.txt b/requirements/heroku.txt
new file mode 100644
index 0000000..3b41dc2
--- /dev/null
+++ b/requirements/heroku.txt
@@ -0,0 +1,9 @@
+# requirements necessary when deploying the test project to heroku
+.[validation]
+Django>=1.11.7,<2.0; python_version <= "2.7"
+Django>=1.11.7; python_version >= "3.4"
+
+-r testproj.txt
+psycopg2>=2.7.3
+gunicorn>=19.7.1
+whitenoise>=3.3.1
diff --git a/requirements/testproj.txt b/requirements/testproj.txt
index 731c23b..958b760 100644
--- a/requirements/testproj.txt
+++ b/requirements/testproj.txt
@@ -5,3 +5,5 @@ django-cors-headers>=2.1.0
 django-filter>=1.1.0,<2.0; python_version == "2.7"
 django-filter>=1.1.0; python_version >= "3.4"
 djangorestframework-camel-case>=0.2.0
+dj-database-url>=0.4.2
+user_agents>=1.1.0
diff --git a/requirements/tox.txt b/requirements/tox.txt
index ce2881f..29119f6 100644
--- a/requirements/tox.txt
+++ b/requirements/tox.txt
@@ -1,6 +1,4 @@
 # requirements for building and running tox
 tox>=2.9.1
-tox-battery>=0.5
-detox>=0.11
 
 -r setup.txt
diff --git a/runtime.txt b/runtime.txt
new file mode 100644
index 0000000..5c45380
--- /dev/null
+++ b/runtime.txt
@@ -0,0 +1 @@
+python-3.6.4
diff --git a/setup.py b/setup.py
index b641696..33a84f4 100644
--- a/setup.py
+++ b/setup.py
@@ -3,6 +3,8 @@
 import distutils.core
 import io
 import os
+import random
+import string
 import sys
 from setuptools import find_packages, setup
 
@@ -32,14 +34,14 @@ def _install_setup_requires(attrs):
         dist.fetch_build_eggs(dist.setup_requires)
 
 
-if 'sdist' in sys.argv:
-    try:
-        # try to install setuptools_scm before setuptools does it, otherwise our monkey patch below will come too early
-        # (setuptools_scm adds find_files hooks into setuptools on install)
-        _install_setup_requires({'setup_requires': requirements_setup})
-    except Exception:
-        pass
+try:
+    # try to install setuptools_scm before setuptools does it, otherwise our monkey patch below will come too early
+    # (setuptools_scm adds find_files hooks into setuptools on install)
+    _install_setup_requires({'setup_requires': requirements_setup})
+except Exception:
+    pass
 
+if 'sdist' in sys.argv:
     try:
         # see https://github.com/pypa/setuptools_scm/issues/190, setuptools_scm includes ALL versioned files from
         # the git repo into the sdist by default, and there is no easy way to provide an opt-out;
@@ -51,9 +53,22 @@ if 'sdist' in sys.argv:
     except ImportError:
         pass
 
+try:
+    # this is a workaround for being able to install the package from source without working from a git checkout
+    # it is needed for building succesfully on Heroku
+    from setuptools_scm import get_version
+
+    version = get_version()
+    version_kwargs = {'use_scm_version': True}
+except LookupError:
+    if 'sdist' in sys.argv or 'bdist_wheel' in sys.argv:
+        raise
+
+    rnd = ''.join(random.choice(string.ascii_lowercase + string.digits) for _ in range(16))
+    version_kwargs = {'version': '0.0.0.dummy+' + rnd}
+
 setup(
     name='drf-yasg',
-    use_scm_version=True,
     packages=find_packages('src'),
     package_dir={'': 'src'},
     include_package_data=True,
@@ -89,4 +104,5 @@ setup(
         'Topic :: Documentation',
         'Topic :: Software Development :: Code Generators',
     ],
+    **version_kwargs
 )
diff --git a/src/drf_yasg/inspectors/field.py b/src/drf_yasg/inspectors/field.py
index 0e53806..39928f2 100644
--- a/src/drf_yasg/inspectors/field.py
+++ b/src/drf_yasg/inspectors/field.py
@@ -462,8 +462,10 @@ else:
         """Converts property names to camelCase if ``CamelCaseJSONParser`` or ``CamelCaseJSONRenderer`` are used."""
 
         def is_camel_case(self):
-            return any(issubclass(parser, CamelCaseJSONParser) for parser in self.view.parser_classes) \
-                   or any(issubclass(renderer, CamelCaseJSONRenderer) for renderer in self.view.renderer_classes)
+            return (
+                any(issubclass(parser, CamelCaseJSONParser) for parser in self.view.parser_classes) or
+                any(issubclass(renderer, CamelCaseJSONRenderer) for renderer in self.view.renderer_classes)
+            )
 
         def process_result(self, result, method_name, obj, **kwargs):
             if isinstance(result, openapi.Schema.OR_REF) and self.is_camel_case():
diff --git a/testproj/createsuperuser.py b/testproj/createsuperuser.py
index ce76187..1fe8294 100644
--- a/testproj/createsuperuser.py
+++ b/testproj/createsuperuser.py
@@ -1,11 +1,15 @@
 from __future__ import print_function
 
 from django.contrib.auth.models import User
+from django.db.utils import IntegrityError
 
 username = 'admin'
 email = 'admin@admin.admin'
 password = 'passwordadmin'
-User.objects.filter(username=username).delete()
-User.objects.create_superuser(username, email, password)
 
-print("Created superuser '%s <%s>' with password '%s'" % (username, email, password))
+try:
+    User.objects.create_superuser(username, email, password)
+except IntegrityError:
+    print("User '%s <%s>' already exists" % (username, email))
+else:
+    print("Created superuser '%s <%s>' with password '%s'" % (username, email, password))
diff --git a/testproj/manage.py b/testproj/manage.py
index 0984df0..431d446 100644
--- a/testproj/manage.py
+++ b/testproj/manage.py
@@ -3,7 +3,7 @@ import os
 import sys
 
 if __name__ == "__main__":
-    os.environ.setdefault("DJANGO_SETTINGS_MODULE", "testproj.settings")
+    os.environ.setdefault("DJANGO_SETTINGS_MODULE", "testproj.settings.local")
     try:
         from django.core.management import execute_from_command_line
     except ImportError:
diff --git a/testproj/requirements.txt b/testproj/requirements.txt
index 3b10677..c1ff544 100644
--- a/testproj/requirements.txt
+++ b/testproj/requirements.txt
@@ -1,3 +1,4 @@
-drf-yasg[validation]
-Django>=1.11.7
+..[validation]
+Django>=1.11.7,<2.0; python_version <= "2.7"
+Django>=1.11.7; python_version >= "3.4"
 -r ../requirements/testproj.txt
diff --git a/testproj/testproj/settings/__init__.py b/testproj/testproj/settings/__init__.py
new file mode 100644
index 0000000..e69de29
diff --git a/testproj/testproj/settings.py b/testproj/testproj/settings/base.py
similarity index 85%
rename from testproj/testproj/settings.py
rename to testproj/testproj/settings/base.py
index 5e643a9..1f63072 100644
--- a/testproj/testproj/settings.py
+++ b/testproj/testproj/settings/base.py
@@ -1,16 +1,7 @@
 import os
 
 # Build paths inside the project like this: os.path.join(BASE_DIR, ...)
-BASE_DIR = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
-
-# Quick-start development settings - unsuitable for production
-# See https://docs.djangoproject.com/en/1.11/howto/deployment/checklist/
-
-# SECURITY WARNING: keep the secret key used in production secret!
-SECRET_KEY = '!z1yj(9uz)zk0gg@5--j)bc4h^i!8))r^dezco8glf190e0&#p'
-
-# SECURITY WARNING: don't run with debug turned on in production!
-DEBUG = True
+BASE_DIR = os.path.dirname(os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
 
 ALLOWED_HOSTS = [
     '127.0.0.1',
@@ -69,16 +60,6 @@ TEMPLATES = [
 
 WSGI_APPLICATION = 'testproj.wsgi.application'
 
-# Database
-# https://docs.djangoproject.com/en/1.11/ref/settings/#databases
-
-DATABASES = {
-    'default': {
-        'ENGINE': 'django.db.backends.sqlite3',
-        'NAME': os.path.join(BASE_DIR, 'db.sqlite3'),
-    }
-}
-
 # Password validation
 # https://docs.djangoproject.com/en/1.11/ref/settings/#auth-password-validators
 
@@ -97,16 +78,19 @@ AUTH_PASSWORD_VALIDATORS = [
     },
 ]
 
+# Django Rest Framework
+
 REST_FRAMEWORK = {
     'DEFAULT_PERMISSION_CLASSES': (
         'rest_framework.permissions.IsAuthenticated',
     )
 }
 
+# drf-yasg
+
 SWAGGER_SETTINGS = {
     'LOGIN_URL': '/admin/login',
     'LOGOUT_URL': '/admin/logout',
-    'VALIDATOR_URL': 'http://localhost:8189',
 
     'DEFAULT_INFO': 'testproj.urls.swagger_info'
 }
@@ -128,9 +112,14 @@ USE_TZ = True
 # https://docs.djangoproject.com/en/1.11/howto/static-files/
 
 STATIC_URL = '/static/'
+STATIC_ROOT = os.path.join(BASE_DIR, 'staticfiles')
+
+# Testing
 
 TEST_RUNNER = 'testproj.runner.PytestTestRunner'
 
+# Logging configuration
+
 LOGGING = {
     'version': 1,
     'disable_existing_loggers': True,
diff --git a/testproj/testproj/settings/heroku.py b/testproj/testproj/settings/heroku.py
new file mode 100644
index 0000000..61ea1f1
--- /dev/null
+++ b/testproj/testproj/settings/heroku.py
@@ -0,0 +1,35 @@
+import dj_database_url
+
+from .base import *  # noqa: F403
+
+DEBUG = True
+
+ALLOWED_HOSTS.append('.herokuapp.com')
+
+SECRET_KEY = os.getenv('DJANGO_SECRET_KEY')
+assert SECRET_KEY, 'DJANGO_SECRET_KEY environment variable must be set'
+
+SESSION_COOKIE_SECURE = True
+CSRF_COOKIE_SECURE = True
+
+SECURE_BROWSER_XSS_FILTER = True
+SECURE_CONTENT_TYPE_NOSNIFF = True
+X_FRAME_OPTIONS = 'DENY'
+
+# Simplified static file serving.
+# https://warehouse.python.org/project/whitenoise/
+
+STATICFILES_STORAGE = 'whitenoise.storage.CompressedManifestStaticFilesStorage'
+MIDDLEWARE.insert(0, 'whitenoise.middleware.WhiteNoiseMiddleware')
+
+# Database
+# https://docs.djangoproject.com/en/1.11/ref/settings/#databases
+
+DATABASES = {
+    'default': dj_database_url.config(conn_max_age=600)
+}
+
+SILENCED_SYSTEM_CHECKS = [
+    'security.W004',  # SECURE_HSTS_SECONDS
+    'security.W008',  # SECURE_SSL_REDIRECT
+]
diff --git a/testproj/testproj/settings/local.py b/testproj/testproj/settings/local.py
new file mode 100644
index 0000000..70077e0
--- /dev/null
+++ b/testproj/testproj/settings/local.py
@@ -0,0 +1,24 @@
+import os
+
+import dj_database_url
+
+from .base import *  # noqa: F403
+
+SWAGGER_SETTINGS.update({'VALIDATOR_URL': 'http://localhost:8189'})
+
+# Database
+# https://docs.djangoproject.com/en/1.11/ref/settings/#databases
+
+db_path = os.path.join(BASE_DIR, 'db.sqlite3')
+DATABASES = {
+    'default': dj_database_url.parse('sqlite:///' + db_path)
+}
+
+# Quick-start development settings - unsuitable for production
+# See https://docs.djangoproject.com/en/1.11/howto/deployment/checklist/
+
+# SECURITY WARNING: keep the secret key used in production secret!
+SECRET_KEY = '!z1yj(9uz)zk0gg@5--j)bc4h^i!8))r^dezco8glf190e0&#p'
+
+# SECURITY WARNING: don't run with debug turned on in production!
+DEBUG = True
diff --git a/testproj/testproj/urls.py b/testproj/testproj/urls.py
index e88dd9e..342da0b 100644
--- a/testproj/testproj/urls.py
+++ b/testproj/testproj/urls.py
@@ -1,5 +1,7 @@
+import user_agents
 from django.conf.urls import include, url
 from django.contrib import admin
+from django.shortcuts import redirect
 from rest_framework import permissions
 from rest_framework.decorators import api_view
 
@@ -9,7 +11,13 @@ from drf_yasg.views import get_schema_view
 swagger_info = openapi.Info(
     title="Snippets API",
     default_version='v1',
-    description="Test description",
+    description="""This is a demo project for the [drf-yasg](https://github.com/axnsan12/drf-yasg) Django Rest Framework library.
+
+The `swagger-ui` view can be found [here](/cached/swagger).  
+The `ReDoc` view can be found [here](/cached/redoc).  
+The swagger YAML document can be found [here](/cached/swagger.yaml).  
+
+You can log in using the pre-existing `admin` user with password `passwordadmin`.""",  # noqa
     terms_of_service="https://www.google.com/policies/terms/",
     contact=openapi.Contact(email="contact@snippets.local"),
     license=openapi.License(name="BSD License"),
@@ -27,6 +35,18 @@ def plain_view(request):
     pass
 
 
+def root_redirect(request):
+    user_agent_string = request.META.get('HTTP_USER_AGENT', '')
+    user_agent = user_agents.parse(user_agent_string)
+
+    if user_agent.is_mobile:
+        schema_view = 'cschema-redoc'
+    else:
+        schema_view = 'cschema-swagger-ui'
+
+    return redirect(schema_view, permanent=True)
+
+
 urlpatterns = [
     url(r'^swagger(?P<format>.json|.yaml)$', SchemaView.without_ui(cache_timeout=0), name='schema-json'),
     url(r'^swagger/$', SchemaView.with_ui('swagger', cache_timeout=0), name='schema-swagger-ui'),
@@ -35,6 +55,8 @@ urlpatterns = [
     url(r'^cached/swagger/$', SchemaView.with_ui('swagger', cache_timeout=None), name='cschema-swagger-ui'),
     url(r'^cached/redoc/$', SchemaView.with_ui('redoc', cache_timeout=None), name='cschema-redoc'),
 
+    url(r'^$', root_redirect),
+
     url(r'^admin/', admin.site.urls),
     url(r'^snippets/', include('snippets.urls')),
     url(r'^articles/', include('articles.urls')),
diff --git a/testproj/testproj/wsgi.py b/testproj/testproj/wsgi.py
index 53bb568..66e3052 100644
--- a/testproj/testproj/wsgi.py
+++ b/testproj/testproj/wsgi.py
@@ -2,6 +2,6 @@ import os
 
 from django.core.wsgi import get_wsgi_application
 
-os.environ.setdefault("DJANGO_SETTINGS_MODULE", "testproj.settings")
+os.environ.setdefault("DJANGO_SETTINGS_MODULE", "testproj.settings.local")
 
 application = get_wsgi_application()
diff --git a/tests/reference.yaml b/tests/reference.yaml
index cea0bfd..0b39daa 100644
--- a/tests/reference.yaml
+++ b/tests/reference.yaml
@@ -1,7 +1,11 @@
 swagger: '2.0'
 info:
   title: Snippets API
-  description: Test description
+  description: "This is a demo project for the [drf-yasg](https://github.com/axnsan12/drf-yasg)\
+    \ Django Rest Framework library.\n\nThe `swagger-ui` view can be found [here](/cached/swagger).\
+    \  \nThe `ReDoc` view can be found [here](/cached/redoc).  \nThe swagger YAML\
+    \ document can be found [here](/cached/swagger.yaml).  \n\nYou can log in using\
+    \ the pre-existing `admin` user with password `passwordadmin`."
   termsOfService: https://www.google.com/policies/terms/
   contact:
     email: contact@snippets.local
diff --git a/tox.ini b/tox.ini
index c05d592..3dcff02 100644
--- a/tox.ini
+++ b/tox.ini
@@ -46,15 +46,16 @@ deps =
     -rrequirements/docs.txt
 commands =
     python setup.py check --restructuredtext --metadata --strict
-    sphinx-build -WnEa -b html docs docs\_build\html
+    sphinx-build -WnEa -b html docs docs/_build/html
 
 [pytest]
-DJANGO_SETTINGS_MODULE = testproj.settings
+DJANGO_SETTINGS_MODULE = testproj.settings.local
 python_paths = testproj
 
 [flake8]
 max-line-length = 120
 exclude = **/migrations/*
+ignore = F405
 
 [isort]
 skip = .eggs,.tox,docs,env,venv
@@ -68,6 +69,7 @@ known_standard_library =
     collections,copy,distutils,functools,inspect,io,json,logging,operator,os,pkg_resources,re,setuptools,sys,
     types,warnings
 known_third_party =
-    coreapi,coreschema,datadiff,django,django_filters,djangorestframework_camel_case,flex,inflection,pygments,
-    pytest,rest_framework,ruamel,setuptools_scm,swagger_spec_validator,uritemplate
+    coreapi,coreschema,datadiff,dj_database_url,django,django_filters,djangorestframework_camel_case,flex,gunicorn,
+    inflection,pygments,pytest,rest_framework,ruamel,setuptools_scm,swagger_spec_validator,uritemplate,user_agents,
+    whitenoise
 known_first_party = drf_yasg,testproj,articles,snippets,users,urlconfs