From f15e70b7db379b0a1af86a3c209f0b6d55adbb37 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cristi=20V=C3=AEjdea?= Date: Thu, 22 Feb 2018 20:33:47 +0200 Subject: [PATCH] Fix missing assignment for default in openapi.Parameter --- docs/changelog.rst | 8 ++++++++ src/drf_yasg/openapi.py | 1 + testproj/articles/serializers.py | 2 +- tests/reference.yaml | 3 ++- 4 files changed, 12 insertions(+), 2 deletions(-) diff --git a/docs/changelog.rst b/docs/changelog.rst index abe6cd7..9cc8b8f 100644 --- a/docs/changelog.rst +++ b/docs/changelog.rst @@ -2,6 +2,14 @@ Changelog ######### + +********* +**1.4.3** +********* + +- **FIXED:** added a missing assignment that would cause the ``default`` argument to ``openapi.Parameter.__init__`` to + be ignored + ********* **1.4.2** ********* diff --git a/src/drf_yasg/openapi.py b/src/drf_yasg/openapi.py index 4397257..3d51093 100644 --- a/src/drf_yasg/openapi.py +++ b/src/drf_yasg/openapi.py @@ -396,6 +396,7 @@ class Parameter(SwaggerDict): self.enum = enum self.pattern = pattern self.items = items + self.default = default self._insert_extras__() if self['in'] == IN_PATH: # path parameters must always be required diff --git a/testproj/articles/serializers.py b/testproj/articles/serializers.py index 0f4186d..6a213f6 100644 --- a/testproj/articles/serializers.py +++ b/testproj/articles/serializers.py @@ -31,7 +31,7 @@ class ArticleSerializer(serializers.ModelSerializer): class ImageUploadSerializer(serializers.Serializer): - what_am_i_doing = serializers.RegexField(regex=r"^69$", help_text="test") + what_am_i_doing = serializers.RegexField(regex=r"^69$", help_text="test", default="69") image_styles = serializers.ListSerializer( child=serializers.ChoiceField(choices=['wide', 'tall', 'thumb', 'social']), help_text="Parameter with Items" diff --git a/tests/reference.yaml b/tests/reference.yaml index 821efda..e82e99e 100644 --- a/tests/reference.yaml +++ b/tests/reference.yaml @@ -198,9 +198,10 @@ paths: - name: what_am_i_doing in: formData description: test - required: true + required: false type: string pattern: ^69$ + default: '69' - name: image_styles in: formData description: Parameter with Items