From b19add7599007326180d905de387bd9bc638f0b8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?H=C3=A5var=20Aamb=C3=B8=20Fosstveit?= Date: Wed, 1 Apr 2020 21:40:55 +0200 Subject: [PATCH] Remove unused and duplicate signaling --- server/lib/Room.js | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/server/lib/Room.js b/server/lib/Room.js index 1afe7a7..ed16f1a 100644 --- a/server/lib/Room.js +++ b/server/lib/Room.js @@ -946,16 +946,10 @@ class Room extends EventEmitter throw new Error('Peer not yet joined'); const { displayName } = request.data; - const oldDisplayName = peer.displayName; peer.displayName = displayName; - // Spread to others - this._notification(peer.socket, 'changeDisplayName', { - peerId : peer.id, - displayName : displayName, - oldDisplayName : oldDisplayName - }, true); + // This will be spread through events from the peer object // Return no error cb(); @@ -963,7 +957,7 @@ class Room extends EventEmitter break; } - case 'changePicture': + /* case 'changePicture': { // Ensure the Peer is joined. if (!peer.joined) @@ -983,7 +977,7 @@ class Room extends EventEmitter cb(); break; - } + } */ case 'chatMessage': {