From c1aa62d22cccd5a185e2393c73194c4c24d258bf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?H=C3=A5var=20Aamb=C3=B8=20Fosstveit?= Date: Wed, 6 May 2020 22:22:57 +0200 Subject: [PATCH] Don't send lobbypeers to client if they don't have PROMOTE_PEER role, fixes #208 --- server/lib/Room.js | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/server/lib/Room.js b/server/lib/Room.js index 69e3e31..02ba41c 100644 --- a/server/lib/Room.js +++ b/server/lib/Room.js @@ -669,7 +669,14 @@ class Room extends EventEmitter .filter((joinedPeer) => joinedPeer.id !== peer.id) .map((joinedPeer) => (joinedPeer.peerInfo)); - const lobbyPeers = this._lobby.peerList(); + let lobbyPeers = []; + + if ( // Allowed to promote peers, notify about lobbypeers + peer.roles.some((role) => + permissionsFromRoles.PROMOTE_PEER.includes(role) + ) + ) + lobbyPeers = this._lobby.peerList(); cb(null, { roles : peer.roles,