From 77245b8fe45f5bd5298126f1f53f3e852c59bbf3 Mon Sep 17 00:00:00 2001 From: Andrea Gelmini Date: Tue, 14 Apr 2020 20:55:39 +0200 Subject: [PATCH 1/2] Fix package name On Debian/Ubuntu it's "build-essential" --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 82a1c6a..e7f947c 100644 --- a/README.md +++ b/README.md @@ -27,7 +27,7 @@ Currently multiparty-meeting will only run on nodejs v10.* To install see here [here](https://github.com/nodesource/distributions/blob/master/README.md#debinstall). ```bash -$ sudo apt install npm build-essentials redis +$ sudo apt install npm build-essential redis ``` * Clone the project: From 250679c6705f72e0f704955cb1b0b5b81b283b5a Mon Sep 17 00:00:00 2001 From: Andrea Gelmini Date: Tue, 14 Apr 2020 20:57:09 +0200 Subject: [PATCH 2/2] Fix typos --- LTI/LTI.md | 4 ++-- README.md | 6 +++--- app/src/RoomClient.js | 22 +++++++++++----------- app/src/__tests__/RoomClient.spec.js | 2 +- app/src/reducers/lobbyPeers.js | 2 +- munin/mm-plugin | 2 +- server/config/config.example.js | 2 +- 7 files changed, 20 insertions(+), 20 deletions(-) diff --git a/LTI/LTI.md b/LTI/LTI.md index ff6b9ec..15b6e6e 100644 --- a/LTI/LTI.md +++ b/LTI/LTI.md @@ -2,7 +2,7 @@ ## LTI -Read more about IMS Global defined interface for tools like our VideoConference system integration with Learning Managment Systems(LMS) (e.g. moodle). +Read more about IMS Global defined interface for tools like our VideoConference system integration with Learning Management Systems(LMS) (e.g. moodle). See: [IMS Global Learning Tool Interoperability](https://www.imsglobal.org/activity/learning-tools-interoperability) We implemented LTI interface version 1.0/1.1 @@ -57,5 +57,5 @@ Open fully the settings **Click on show more!!** ## moodle plugin -Alternativly you can use multipartymeeting moodle plugin: +Alternatively you can use multipartymeeting moodle plugin: [https://github.com/misi/moodle-mod_multipartymeeting](https://github.com/misi/moodle-mod_multipartymeeting) diff --git a/README.md b/README.md index e7f947c..18ddd71 100644 --- a/README.md +++ b/README.md @@ -76,7 +76,7 @@ $ npm install $ cd server $ npm start ``` -* Note: Do not run the server as root. If you need to use port 80/443 make a iptables-mapping for that or use systemd configuration for that (see futher down this doc). +* Note: Do not run the server as root. If you need to use port 80/443 make a iptables-mapping for that or use systemd configuration for that (see further down this doc). * Test your service in a webRTC enabled browser: `https://yourDomainOrIPAdress:3443/roomname` ## Deploy it in a server @@ -102,7 +102,7 @@ $ systemctl enable multiparty-meeting ## Ports and firewall * 3443/tcp (default https webserver and signaling - adjustable in `server/config.js`) -* 4443/tcp (default `npm start` port for developing with live browser reload, not needed in production enviroments - adjustable in app/package.json) +* 4443/tcp (default `npm start` port for developing with live browser reload, not needed in production environments - adjustable in app/package.json) * 40000-49999/udp/tcp (media ports - adjustable in `server/config.js`) ## Load balanced installation @@ -113,7 +113,7 @@ To integrate with an LMS (e.g. Moodle), have a look at [LTI](LTI/LTI.md). ## TURN configuration -* You need an addtional [TURN](https://github.com/coturn/coturn)-server for clients located behind restrictive firewalls! Add your server and credentials to `app/config.js` +* You need an additional [TURN](https://github.com/coturn/coturn)-server for clients located behind restrictive firewalls! Add your server and credentials to `app/config.js` ## Authors diff --git a/app/src/RoomClient.js b/app/src/RoomClient.js index f783957..f8c00e9 100644 --- a/app/src/RoomClient.js +++ b/app/src/RoomClient.js @@ -146,7 +146,7 @@ export default class RoomClient // Whether we should produce. this._produce = produce; - // Wheter we force TCP + // Whether we force TCP this._forceTcp = forceTcp; // Use displayName @@ -269,7 +269,7 @@ export default class RoomClient _startKeyListener() { - // Add keypress event listner on document + // Add keypress event listener on document document.addEventListener('keypress', (event) => { const key = String.fromCharCode(event.which); @@ -572,7 +572,7 @@ export default class RoomClient type : 'error', text : intl.formatMessage({ id : 'room.changeDisplayNameError', - defaultMessage : 'An error occured while changing your display name' + defaultMessage : 'An error occurred while changing your display name' }) })); } @@ -1003,7 +1003,7 @@ export default class RoomClient { // The exact formula to convert from dBs (-100..0) to linear (0..1) is: // Math.pow(10, dBs / 20) - // However it does not produce a visually useful output, so let exagerate + // However it does not produce a visually useful output, so let exaggerate // it a bit. Also, let convert it from 0..1 to 0..10 and avoid value 1 to // minimize component renderings. let volume = Math.round(Math.pow(10, dBs / 85) * 10); @@ -1618,7 +1618,7 @@ export default class RoomClient { // The exact formula to convert from dBs (-100..0) to linear (0..1) is: // Math.pow(10, dBs / 20) - // However it does not produce a visually useful output, so let exagerate + // However it does not produce a visually useful output, so let exaggerate // it a bit. Also, let convert it from 0..1 to 0..10 and avoid value 1 to // minimize component renderings. let volume = Math.round(Math.pow(10, dBs / 85) * 10); @@ -2265,7 +2265,7 @@ export default class RoomClient this.updateSpotlights(spotlights); }); - // Don't produce if explicitely requested to not to do it. + // Don't produce if explicitly requested to not to do it. if (this._produce) { if (this._mediasoupDevice.canProduce('audio')) @@ -2278,7 +2278,7 @@ export default class RoomClient store.dispatch(roomActions.setRoomState('connected')); - // Clean all the existing notifcations. + // Clean all the existing notifications. store.dispatch(notificationActions.removeAllNotifications()); this.getServerHistory(); @@ -2539,7 +2539,7 @@ export default class RoomClient { // The exact formula to convert from dBs (-100..0) to linear (0..1) is: // Math.pow(10, dBs / 20) - // However it does not produce a visually useful output, so let exagerate + // However it does not produce a visually useful output, so let exaggerate // it a bit. Also, let convert it from 0..1 to 0..10 and avoid value 1 to // minimize component renderings. let volume = Math.round(Math.pow(10, dBs / 85) * 10); @@ -2566,7 +2566,7 @@ export default class RoomClient type : 'error', text : intl.formatMessage({ id : 'devices.microphoneError', - defaultMessage : 'An error occured while accessing your microphone' + defaultMessage : 'An error occurred while accessing your microphone' }) })); @@ -2736,7 +2736,7 @@ export default class RoomClient type : 'error', text : intl.formatMessage({ id : 'devices.screenSharingError', - defaultMessage : 'An error occured while accessing your screen' + defaultMessage : 'An error occurred while accessing your screen' }) })); @@ -2912,7 +2912,7 @@ export default class RoomClient type : 'error', text : intl.formatMessage({ id : 'devices.cameraError', - defaultMessage : 'An error occured while accessing your camera' + defaultMessage : 'An error occurred while accessing your camera' }) })); diff --git a/app/src/__tests__/RoomClient.spec.js b/app/src/__tests__/RoomClient.spec.js index 086e6a5..5e1191c 100644 --- a/app/src/__tests__/RoomClient.spec.js +++ b/app/src/__tests__/RoomClient.spec.js @@ -1,6 +1,6 @@ import RoomClient from '../RoomClient'; -describe('new RoomClient() without paramaters throws Error', () => +describe('new RoomClient() without parameters throws Error', () => { test('Matches the snapshot', () => { diff --git a/app/src/reducers/lobbyPeers.js b/app/src/reducers/lobbyPeers.js index fef9190..4cf9cc1 100644 --- a/app/src/reducers/lobbyPeers.js +++ b/app/src/reducers/lobbyPeers.js @@ -44,7 +44,7 @@ const lobbyPeers = (state = {}, action) => if (!oldLobbyPeer) { - // Tried to update non-existant lobbyPeer. Has probably been promoted, or left. + // Tried to update non-existent lobbyPeer. Has probably been promoted, or left. return state; } diff --git a/munin/mm-plugin b/munin/mm-plugin index d319ad1..978995b 100755 --- a/munin/mm-plugin +++ b/munin/mm-plugin @@ -42,7 +42,7 @@ fi if [ "$1" = "config" ]; then echo 'graph_title MM stats' #echo 'graph_args --base 1000 -l 0' - echo 'graph_vlabel Actual Seesion Count' + echo 'graph_vlabel Actual Session Count' echo 'graph_category other' echo 'graph_info This graph shows the mm stats.' echo 'rooms.label rooms' diff --git a/server/config/config.example.js b/server/config/config.example.js index 2ecad55..c320583 100644 --- a/server/config/config.example.js +++ b/server/config/config.example.js @@ -42,7 +42,7 @@ module.exports = key : `${__dirname}/../certs/mediasoup-demo.localhost.key.pem` }, // listening Host or IP - // If ommitted listens on every IP. ("0.0.0.0" and "::") + // If omitted listens on every IP. ("0.0.0.0" and "::") //listeningHost: 'localhost', // Listening port for https server. listeningPort : 443,