From f0c3b16197ec3f24c1afe9b8bdaca1239677a94c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=C3=A9sz=C3=A1ros=20Mih=C3=A1ly?= Date: Wed, 22 Apr 2020 23:45:13 +0200 Subject: [PATCH] Add new app config audioOutputSupportedBrowsers and tidy --- app/public/config/config.example.js | 10 ++++++++++ app/src/components/Settings/Settings.js | 6 ++++-- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/app/public/config/config.example.js b/app/public/config/config.example.js index 9aaff4b..9e16360 100644 --- a/app/public/config/config.example.js +++ b/app/public/config/config.example.js @@ -25,6 +25,16 @@ var config = { scaleResolutionDownBy: 2 }, { scaleResolutionDownBy: 1 } ], + /** + * White listing browsers that support audio output device selection. + * It is not yet fully implemented in Firefox. + * See: https://bugzilla.mozilla.org/show_bug.cgi?id=1498512 + */ + audioOutputSupportedBrowsers : + [ + 'chrome', + 'opera' + ], // Socket.io request timeout requestTimeout : 10000, transportOptions : diff --git a/app/src/components/Settings/Settings.js b/app/src/components/Settings/Settings.js index ad1d245..1945ef2 100644 --- a/app/src/components/Settings/Settings.js +++ b/app/src/components/Settings/Settings.js @@ -234,7 +234,9 @@ const Settings = ({ - { browser.name === 'chrome' && + { + window.config.audioOutputSupportedBrowsers && + window.config.audioOutputSupportedBrowsers.includes(browser.name) &&