Briq
/
multiparty-meeting
7
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove video frame rate and screen sharing resolution, these are probably not required. Still configurable in app config. Fixes #415

auto_join_3.3
Håvar Aambø Fosstveit 2020-05-22 20:42:22 +02:00
parent ed0af0cd50
commit f546e22ae1
1 changed files with 58 additions and 56 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

114
app/src/components/Settings/MediaSettings.js
View File

@ -239,62 +239,64 @@ const MediaSettings = ({
/> />
</FormHelperText> </FormHelperText>
</FormControl> </FormControl>
<FormControl className={classes.formControl}> { /*
<Select <FormControl className={classes.formControl}>
value={settings.frameRate || ''} <Select
onChange={(event) => value={settings.frameRate || ''}
{ onChange={(event) =>
if (event.target.value) {
roomClient.updateWebcam({ newFrameRate: event.target.value }); if (event.target.value)
}} roomClient.updateWebcam({ newFrameRate: event.target.value });
name='Frame rate' }}
autoWidth name='Frame rate'
className={classes.selectEmpty} autoWidth
> className={classes.selectEmpty}
{ [ 1, 5, 10, 15, 20, 25, 30 ].map((frameRate) => >
{ { [ 1, 5, 10, 15, 20, 25, 30 ].map((frameRate) =>
return ( {
<MenuItem key={frameRate} value={frameRate}> return (
{frameRate} <MenuItem key={frameRate} value={frameRate}>
</MenuItem> {frameRate}
); </MenuItem>
})} );
</Select> })}
<FormHelperText> </Select>
<FormattedMessage <FormHelperText>
id='settings.frameRate' <FormattedMessage
defaultMessage='Select your video frame rate' id='settings.frameRate'
/> defaultMessage='Select your video frame rate'
</FormHelperText> />
</FormControl> </FormHelperText>
<FormControl className={classes.formControl}> </FormControl>
<Select <FormControl className={classes.formControl}>
value={settings.screenSharingResolution || ''} <Select
onChange={(event) => value={settings.screenSharingResolution || ''}
{ onChange={(event) =>
if (event.target.value) {
roomClient.updateScreenSharing({ newResolution: event.target.value }); if (event.target.value)
}} roomClient.updateScreenSharing({ newResolution: event.target.value });
name='Screen sharing resolution' }}
autoWidth name='Screen sharing resolution'
className={classes.selectEmpty} autoWidth
> className={classes.selectEmpty}
{resolutions.map((resolution, index) => >
{ {resolutions.map((resolution, index) =>
return ( {
<MenuItem key={index} value={resolution.value}> return (
{resolution.label} <MenuItem key={index} value={resolution.value}>
</MenuItem> {resolution.label}
); </MenuItem>
})} );
</Select> })}
<FormHelperText> </Select>
<FormattedMessage <FormHelperText>
id='settings.screenSharingResolution' <FormattedMessage
defaultMessage='Select your screen sharing resolution' id='settings.screenSharingResolution'
/> defaultMessage='Select your screen sharing resolution'
</FormHelperText> />
</FormControl> </FormHelperText>
</FormControl>
*/ }
<FormControl className={classes.formControl}> <FormControl className={classes.formControl}>
<Select <Select
value={settings.screenSharingFrameRate || ''} value={settings.screenSharingFrameRate || ''}