From fd5894091645567bb13573a5af94f73bc1f9b60a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?H=C3=A5var=20Aamb=C3=B8=20Fosstveit?= Date: Wed, 18 Mar 2020 10:07:15 +0100 Subject: [PATCH] Constrain screensharing in getDisplayMedia --- app/src/RoomClient.js | 6 +++--- app/src/ScreenShare.js | 17 +++++++++++++++-- 2 files changed, 18 insertions(+), 5 deletions(-) diff --git a/app/src/RoomClient.js b/app/src/RoomClient.js index 8b97745..73cb6ea 100644 --- a/app/src/RoomClient.js +++ b/app/src/RoomClient.js @@ -2484,9 +2484,9 @@ export default class RoomClient logger.debug('enableScreenSharing() | calling getUserMedia()'); const stream = await this._screenSharing.start({ - width : 1280, - height : 720, - frameRate : 3 + width : 1920, + height : 1080, + frameRate : 5 }); track = stream.getVideoTracks()[0]; diff --git a/app/src/ScreenShare.js b/app/src/ScreenShare.js index c819fb2..180fe2a 100644 --- a/app/src/ScreenShare.js +++ b/app/src/ScreenShare.js @@ -101,12 +101,25 @@ class DisplayMediaScreenShare return true; } - _toConstraints() + _toConstraints(options) { const constraints = { - video : true + video : {} }; + if (isFinite(options.width)) + { + constraints.video.width = options.width; + } + if (isFinite(options.height)) + { + constraints.video.height = options.height; + } + if (isFinite(options.frameRate)) + { + constraints.video.frameRate = options.frameRate; + } + return constraints; } }