Commit Graph

515 Commits (186f9548b17f82894e249212b277809a465e9702)

Author SHA1 Message Date
Diederik van der Boor 186f9548b1 Bump to v1.0.2 2016-10-14 11:51:03 +02:00
Diederik van der Boor 58f89efa5d Brush up the `ParentAdminNotRegistered` fix a bit for flow clarity. 2016-10-14 11:51:03 +02:00
Diederik van der Boor 3570d10754 Merge pull request #246 from ixc/feature/fix-non-root-parent-admin-lookup
Fix get parent admin when intermediate not root ctype model is registered
2016-10-14 11:40:10 +02:00
James Murty 37f92b3a3f Fix get parent admin when intermediate not root ctype model is registered
This change fixes an issue where django-polymorphic raises a
`ParentAdminNotRegistered` exception when you register an admin for a
child model ancestor, but not for the root ancestor as pointed to by
the `polymorphic_ctype` field. This error occurs only when you *Save*
the child model detail form, not when you *Save and continue* on that
same form.

This situation occurs for us when using django-fluent-pages version
1.0.1 which has an intermediate `Page` model registered with a parent
admin to show the pages listing. The existing `_get_parent_admin` method
expects an admin to be registered for the root `UrlNode` model pointed
to by the `polymorphic_ctype` field.

This fix uses a potentially naive and slow brute-force approach where
it walks up the class hierarchy and checks  whether a parent admin is
registered for each ancestor model, unless/until it finds one.

See also https://github.com/ic-labs/django-icekit/issues/31/
2016-10-13 09:35:13 +11:00
Diederik van der Boor db6d7ed213 Update changelog with recent git changes 2016-10-04 11:21:20 +02:00
Diederik van der Boor 35dec27696 Remove unsupported fk_name parameter for `polymorphic_modelformset_factory()`
Fixes #243
2016-10-04 10:33:59 +02:00
Diederik van der Boor 3dcb8e7e06 Merge pull request #242 from chrisbrantley/chrisbrantley-patch-1
Wrap call to key() in list() so it can be indexed
2016-10-04 10:31:51 +02:00
Diederik van der Boor 19745c6740 Merge pull request #241 from benkonrath/fix-contrib-guardian-docs
Improve django-guardian integration docs.
2016-10-04 10:31:14 +02:00
Diederik van der Boor f4bee9d34f Merge pull request #240 from AlJohri/patch-1
change django 1.9 to 1.10 in quickstart
2016-10-04 10:30:39 +02:00
Diederik van der Boor a527fd5da6 Merge pull request #239 from angvp/readme_improvements
Readme improvements
2016-10-04 10:30:23 +02:00
Chris Brantley 8043e87b30 Wrap call to key() in list() so it can be indexed
In Python 3.4 trying to generate a polymorphic_inlineformset results in a TypeError with the following message: "'KeysView' object does not support indexing". This solves that problem by ensuring that `child_models` is a list, and thus can be referenced by index.
2016-09-21 09:56:20 -05:00
Ben Konrath d7fb5a1fac Improve django-guardian integration docs. 2016-09-20 21:40:45 +02:00
Al Johri a49daa65a9 change django 1.9 to 1.10 in quickstart 2016-09-20 00:23:41 -04:00
Angel Velasquez 8bd040a15c Add installation instructions on README 2016-09-19 14:52:13 -03:00
Angel Velasquez 0da4c7ad29 Fix link of pypi it was taking data from polymorphic-tree instead polymorphic 2016-09-19 14:50:23 -03:00
Diederik van der Boor badad18a63 Merge pull request #238 from Quantra/dev
CSS tweak for Grappelli
2016-09-12 10:45:23 +02:00
Diederik van der Boor 7cd5f8455a Merge pull request #235 from benkonrath/contrib-guardian
Add helper function for django-guardian.
2016-09-12 10:44:50 +02:00
Diederik van der Boor 7fec242912 add missing changelog entry for 0.9 2016-09-12 10:39:54 +02:00
Diederik van der Boor e76259fa2e Fix dumpdata hack on Windows 2016-09-12 10:35:47 +02:00
Diederik van der Boor 8f9f8ab4f7 Bump to 1.0.1 2016-09-11 21:34:37 +02:00
Diederik van der Boor c97d1ef088 Let tests pass on Django 1.10.1
The change for https://code.djangoproject.com/ticket/27073
in d4eefc7e2a
removed the _default_manager assignment
2016-09-11 21:32:19 +02:00
Quantra 20675986ba Update polymorphic_inlines.css
Prevent div.polymorphic-add-choice overlapping previous inline formset when using Grappelli.
2016-09-03 15:14:01 +01:00
Diederik van der Boor 2d6832f844 Bump to 1.0 2016-09-02 12:42:22 +02:00
Diederik van der Boor 741f7fdf5f Fix using MANIFEST.in for wheel too
sdist always read MANIFEST.in, wheel used `package_data` setting.
2016-09-02 12:42:22 +02:00
Diederik van der Boor 1f1096046e Remove setuptools from install_requires 2016-09-02 12:42:22 +02:00
Diederik van der Boor c8dd04bba0 Add explicit .empty-form hiding for grapelli 2016-09-02 10:41:47 +02:00
Ben Konrath c695029cfa Add helper function for django-guardian. 2016-09-01 12:15:21 +02:00
Diederik van der Boor 8811c177bd remove unneeded import 2016-08-15 16:10:55 +02:00
Diederik van der Boor 83cb059317 Fix marking a new formset item as empty-form on postback errors 2016-08-15 16:03:08 +02:00
Diederik van der Boor d70735c849 Exclude Python 3.2 3.2 on newer Django. 2016-08-15 11:33:20 +02:00
Diederik van der Boor 4a60c1fb60 Bump to 1.0b1 2016-08-15 11:22:45 +02:00
Diederik van der Boor 22cef13f69 Fix Python 3 tests 2016-08-10 14:29:03 +02:00
Diederik van der Boor e20401d8bc Fixed the Python 3 unittests 2016-08-10 14:02:36 +02:00
Diederik van der Boor cf1d4b532d Merge branch 'django110' 2016-08-10 13:55:37 +02:00
Diederik van der Boor b4a02e9c47 Let last base_manager test allow different results in Django 1.10
This is after all, how Django 1.10's new base manager works.
2016-08-10 13:55:09 +02:00
Diederik van der Boor bb0e71ee8f autopep8 by pycharm 2016-08-10 13:54:44 +02:00
Diederik van der Boor 10ab3ad14c Fix compatibility with older Django versions 2016-08-10 13:51:30 +02:00
Diederik van der Boor 3817061467 Fix unit tests for defer() / only()
Added get_deferred_fields() to ShowFieldBase
2016-08-10 13:43:31 +02:00
Diederik van der Boor dd89458615 Fixed expressions unit test, DateTime refactored in Django 1.10 2016-08-10 13:20:16 +02:00
Diederik van der Boor 2ee9ceed02 update changelog too 2016-08-10 13:04:55 +02:00
Diederik van der Boor 8b50942292 Update documentation 2016-08-10 13:03:51 +02:00
Diederik van der Boor 8bce015199 Add missing `polymorphic_modelformset_factory` method 2016-08-10 12:50:15 +02:00
Diederik van der Boor 352b56e104 Merge branch 'feature/inlines' 2016-08-10 11:48:02 +02:00
Diederik van der Boor 60db4f63b9 Update polymorphic inline script.
Now based on standard Django script.
This makes upgrading it to newer Django versions much easier.
Changes for polymorphic are included in this commit
2016-08-10 11:45:48 +02:00
Diederik van der Boor 249fc0088b Import standard Django inlines script, to be adjusted for polymorphic 2016-08-10 11:42:31 +02:00
Diederik van der Boor 59e3878835 Add detection for missing PolymorphicInlineSupportMixin 2016-08-09 01:21:37 +02:00
Diederik van der Boor a533dc4b23 Update example to show polymorphic inlines 2016-08-09 01:21:21 +02:00
Diederik van der Boor 7330a4f099 Add preliminairy working JavaScript to render polymorphic inlines 2016-08-09 01:20:40 +02:00
Diederik van der Boor 1f0ddd8436 Rename inline/formset classes to avoid more confusion.
AbstractSingletonProxyFactoryBean danger luked here...
Added the Stacked...Inline for clarity too.
2016-08-09 01:11:05 +02:00
Diederik van der Boor 2e694fb2c6 Fix for removed `Q.clone()` method in Django 1.10 2016-08-05 17:26:32 +02:00