Hide advanced video settings by default, ref #415

app/src/components/Settings/MediaSettings.js

@@ -95,6 +95,9 @@ const MediaSettings = ({
 {
 	const intl = useIntl();
 
+	const [ audioSettingsOpen, setAudioSettingsOpen ] = React.useState(false);
+	const [ videoSettingsOpen, setVideoSettingsOpen ] = React.useState(false);
+
 	const resolutions = [ {
 		value : 'low',
 		label : intl.formatMessage({
@@ -152,13 +155,6 @@ const MediaSettings = ({
 	else
 		audioOutputDevices = [];
 
-	const [ open, setOpen ] = React.useState(true);
-
-	const advancedAudioSettings = () =>
-	{
-		setOpen(!open);
-	};
-
 	return (
 		<React.Fragment>
 			<form className={classes.setting} autoComplete='off'>
@@ -205,6 +201,16 @@ const MediaSettings = ({
 						}
 					</FormHelperText>
 				</FormControl>
+				<List className={classes.root} component='nav'>
+					<ListItem button onClick={() => setVideoSettingsOpen(!videoSettingsOpen)}>
+						<ListItemText primary={intl.formatMessage({
+							id             : 'settings.showAdvancedVideo',
+							defaultMessage : 'Advanced video settings'
+						})}
+						/>
+						{videoSettingsOpen ? <ExpandLess /> : <ExpandMore />}
+					</ListItem>
+					<Collapse in={videoSettingsOpen} timeout='auto'>
 						<FormControl className={classes.formControl}>
 							<Select
 								value={settings.resolution || ''}
@@ -317,6 +323,8 @@ const MediaSettings = ({
 								/>
 							</FormHelperText>
 						</FormControl>
+					</Collapse>
+				</List>
 			</form>
 			<form className={classes.setting} autoComplete='off'>
 				<FormControl className={classes.formControl}>
@@ -357,10 +365,8 @@ const MediaSettings = ({
 						}
 					</FormHelperText>
 				</FormControl>
-			</form>
 				{ 'audioOutputSupportedBrowsers' in window.config &&
 					window.config.audioOutputSupportedBrowsers.includes(me.browser.name) &&
-				<form className={classes.setting} autoComplete='off'>
 					<FormControl className={classes.formControl}>
 						<Select
 							value={settings.selectedAudioOutputDevice || ''}
@@ -404,18 +410,17 @@ const MediaSettings = ({
 							}
 						</FormHelperText>
 					</FormControl>
-				</form>
 				}
 				<List className={classes.root} component='nav'>
-				<ListItem button onClick={advancedAudioSettings}>
+					<ListItem button onClick={() => setAudioSettingsOpen(!audioSettingsOpen)}>
 						<ListItemText primary={intl.formatMessage({
 							id             : 'settings.showAdvancedAudio',
-						defaultMessage : 'Show advanced audio settings'
+							defaultMessage : 'Advanced audio settings'
 						})}
 						/>
-					{open ? <ExpandLess /> : <ExpandMore />}
+						{audioSettingsOpen ? <ExpandLess /> : <ExpandMore />}
 					</ListItem>
-				<Collapse in={!open} timeout='auto'>
+					<Collapse in={audioSettingsOpen} timeout='auto'>
 						<List component='div'>
 							<ListItem className={classes.nested}>
 								<FormControlLabel
@@ -520,6 +525,7 @@ const MediaSettings = ({
 						</List>
 					</Collapse>
 				</List>
+			</form>
 		</React.Fragment>
 	);
 };

app/src/translations/cn.json

@@ -144,6 +144,7 @@
 	"settings.notificationSounds": null,
 	"settings.showNotifications": null,
 	"settings.buttonControlBar": null,
+	"settings.showAdvancedVideo": null,
 	"settings.showAdvancedAudio": null,
 	"settings.echoCancellation": null,
 	"settings.autoGainControl": null,

app/src/translations/cs.json

@@ -143,6 +143,7 @@
 	"settings.notificationSounds": null,
 	"settings.showNotifications": null,
 	"settings.buttonControlBar": null,
+	"settings.showAdvancedVideo": null,
 	"settings.showAdvancedAudio": null,
 	"settings.echoCancellation": null,
 	"settings.autoGainControl": null,

app/src/translations/de.json

@@ -144,6 +144,7 @@
 	"settings.notificationSounds": "Audiosignal bei Benachrichtigungen",
 	"settings.showNotifications": "Zeige Benachrichtigungen",
 	"settings.buttonControlBar": "Separate seitliche Medienwerkzeugleiste",
+	"settings.showAdvancedVideo": null,
 	"settings.showAdvancedAudio": "Erweiterte Audio-Einstellungen",
 	"settings.echoCancellation": "Echounterdrückung",
 	"settings.autoGainControl": "Automatische Pegelregelung (Audioeingang)",

app/src/translations/dk.json

@@ -144,6 +144,7 @@
 	"settings.notificationSounds": null,
 	"settings.showNotifications": null,
 	"settings.buttonControlBar": null,
+	"settings.showAdvancedVideo": null,
 	"settings.showAdvancedAudio": null,
 	"settings.echoCancellation": null,
 	"settings.autoGainControl": null,

app/src/translations/el.json

@@ -144,6 +144,7 @@
 	"settings.notificationSounds": null,
 	"settings.showNotifications": null,
 	"settings.buttonControlBar": null,
+	"settings.showAdvancedVideo": null,
 	"settings.showAdvancedAudio": null,
 	"settings.echoCancellation": null,
 	"settings.autoGainControl": null,

app/src/translations/en.json

@@ -144,6 +144,7 @@
 	"settings.notificationSounds": "Notification sounds",
 	"settings.showNotifications": "Show notifications",
 	"settings.buttonControlBar": "Separate media controls",
+	"settings.showAdvancedVideo": "Advanced video settings",
 	"settings.showAdvancedAudio": "Advanced audio settings",
 	"settings.echoCancellation": "Echo cancellation",
 	"settings.autoGainControl": "Auto gain control",

app/src/translations/es.json

@@ -144,6 +144,7 @@
 	"settings.notificationSounds": null,
 	"settings.showNotifications": null,
 	"settings.buttonControlBar": null,
+	"settings.showAdvancedVideo": null,
 	"settings.showAdvancedAudio": null,
 	"settings.echoCancellation": null,
 	"settings.autoGainControl": null,

app/src/translations/fr.json

@@ -144,6 +144,7 @@
 	"settings.notificationSounds": null,
 	"settings.showNotifications": null,
 	"settings.buttonControlBar": null,
+	"settings.showAdvancedVideo": null,
 	"settings.showAdvancedAudio": null,
 	"settings.echoCancellation": null,
 	"settings.autoGainControl": null,

app/src/translations/hr.json

@@ -144,6 +144,7 @@
 	"settings.notificationSounds": "Zvuk obavijesti",
 	"settings.showNotifications": "Prikaži obavijesti",
 	"settings.buttonControlBar": "Razdvoji upravljanje medijima",
+	"settings.showAdvancedVideo": null,
 	"settings.showAdvancedAudio": null,
 	"settings.echoCancellation": "Poništavanje jeke",
 	"settings.autoGainControl": "Automatsko upravljanje jačinom zvuka",

app/src/translations/hu.json

@@ -144,6 +144,7 @@
 	"settings.notificationSounds": "Értesítések hangjelzéssel",
 	"settings.showNotifications": "Értesítések megjelenítése",
 	"settings.buttonControlBar": "Médiavezérlő gombok leválasztása",
+	"settings.showAdvancedVideo": null,
 	"settings.showAdvancedAudio": "Speciális hang beállítások",
 	"settings.echoCancellation": "Visszhangelnyomás",
 	"settings.autoGainControl": "Automatikus hangerő",

app/src/translations/it.json

@@ -144,6 +144,7 @@
 	"settings.notificationSounds": "Suoni di notifica",
 	"settings.showNotifications": "Mostra notifiche",
 	"settings.buttonControlBar": "Controlli media separati",
+	"settings.showAdvancedVideo": null,
 	"settings.showAdvancedAudio": null,
 	"settings.echoCancellation": "Cancellazione echo",
 	"settings.autoGainControl": "Controllo guadagno automatico",

app/src/translations/lv.json

@@ -138,6 +138,7 @@
 	"settings.notificationSounds": "Paziņojumu skaņas",
 	"settings.showNotifications": null,
 	"settings.buttonControlBar": null,
+	"settings.showAdvancedVideo": null,
 	"settings.showAdvancedAudio": null,
 	"settings.echoCancellation": null,
 	"settings.autoGainControl": null,

app/src/translations/nb.json

@@ -140,6 +140,7 @@
 	"settings.advancedMode": "Avansert modus",
 	"settings.permanentTopBar": "Permanent topplinje",
 	"settings.lastn": "Antall videoer synlig",
+	"settings.showAdvancedVideo": "Avanserte videoinnstillinger",
 	"settings.showAdvancedAudio": "Avanserte audioinnstillinger",
 	"settings.hiddenControls": "Skjul media knapper",
 	"settings.notificationSounds": "Varslingslyder",

app/src/translations/pl.json

@@ -144,6 +144,7 @@
 	"settings.notificationSounds": "Powiadomienia dźwiękiem",
 	"settings.showNotifications": "Pokaż powiadomienia",
 	"settings.buttonControlBar": "Rozdziel kontrolki mediów",
+	"settings.showAdvancedVideo": null,
 	"settings.showAdvancedAudio": null,
 	"settings.echoCancellation": "Usuwanie echa",
 	"settings.autoGainControl": "Auto korekta wzmocnienia",

app/src/translations/pt.json

@@ -144,6 +144,7 @@
 	"settings.notificationSounds": null,
 	"settings.showNotifications": null,
 	"settings.buttonControlBar": null,
+	"settings.showAdvancedVideo": null,
 	"settings.showAdvancedAudio": null,
 	"settings.echoCancellation": null,
 	"settings.autoGainControl": null,

app/src/translations/ro.json

@@ -144,6 +144,7 @@
 	"settings.notificationSounds": null,
 	"settings.showNotifications": null,
 	"settings.buttonControlBar": null,
+	"settings.showAdvancedVideo": null,
 	"settings.showAdvancedAudio": null,
 	"settings.echoCancellation": null,
 	"settings.autoGainControl": null,

app/src/translations/tr.json

@@ -141,6 +141,7 @@
 	"settings.notificationSounds": null,
 	"settings.showNotifications": null,
 	"settings.buttonControlBar": null,
+	"settings.showAdvancedVideo": null,
 	"settings.showAdvancedAudio": null,
 	"settings.echoCancellation": null,
 	"settings.autoGainControl": null,

app/src/translations/tw.json

@@ -143,6 +143,7 @@
 	"settings.notificationSounds": "通知音效",
 	"settings.showNotifications": "顯示通知",
 	"settings.buttonControlBar": "獨立控制按鈕",
+	"settings.showAdvancedVideo": null,
 	"settings.showAdvancedAudio": null,
 	"settings.echoCancellation": "回音消除",
 	"settings.autoGainControl": "自動增益控制",

app/src/translations/uk.json

@@ -144,6 +144,7 @@
 	"settings.notificationSounds": null,
 	"settings.showNotifications": null,
 	"settings.buttonControlBar": null,
+	"settings.showAdvancedVideo": null,
 	"settings.showAdvancedAudio": null,
 	"settings.echoCancellation": null,
 	"settings.autoGainControl": null,